Small patch proposal

[Matt Wilbur]

Hi All,

I finally began doing some work on using the Minix C library on the weekend in the fifteen minutes my kids allowed me :)

To that end, I have a wee patch to propose.  The implementation of the device manager leaks into shell.c when the code checks the function pointers for directory functions.  I would suggest we put this check into devman.c (something like dm_dev_has_dir_capability -- I'm not too fussy about the name as long as it's intent is clear).  This will make it easier to encapsulate devman and hence have the implementation (possibly) change depending on the C library.

Matt

_______________________________________________
eLua-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/elua-dev

[BogdanM]

Hi,

On Mon, Jul 4, 2011 at 2:35 PM, Matt Wilbur <[hidden email]> wrote:

Hi All,

I finally began doing some work on using the Minix C library on the weekend in the fifteen minutes my kids allowed me :)

To that end, I have a wee patch to propose.  The implementation of the device manager leaks into shell.c when the code checks the function pointers for directory functions.  I would suggest we put this check into devman.c (something like dm_dev_has_dir_capability -- I'm not too fussy about the name as long as it's intent is clear).  This will make it easier to encapsulate devman and hence have the implementation (possibly) change depending on the C library.

Absolutely, this makes sense. Do you want me to implement that?

Best,

Bogdan

 

_______________________________________________
eLua-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/elua-dev

[Matt Wilbur]

On Mon, Jul 4, 2011 at 7:45 AM, Bogdan Marinescu <[hidden email]> wrote:

Hi,

On Mon, Jul 4, 2011 at 2:35 PM, Matt Wilbur <[hidden email]> wrote:

Hi All,

I finally began doing some work on using the Minix C library on the weekend in the fifteen minutes my kids allowed me :)

To that end, I have a wee patch to propose.  The implementation of the device manager leaks into shell.c when the code checks the function pointers for directory functions.  I would suggest we put this check into devman.c (something like dm_dev_has_dir_capability -- I'm not too fussy about the name as long as it's intent is clear).  This will make it easier to encapsulate devman and hence have the implementation (possibly) change depending on the C library.

Absolutely, this makes sense. Do you want me to implement that?

Whatever's easiest.

Cheers,

Matt

_______________________________________________
eLua-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/elua-dev