Re: eLua-dev Digest, Vol 25, Issue 25

classic Classic list List threaded Threaded
1 message Options
Paul Verbeke Paul Verbeke
Reply | Threaded
Open this post in threaded view
|

Re: eLua-dev Digest, Vol 25, Issue 25

Hi,

Thanks for the update Dado, I will look forward to the binary. In the meantime I will try to get the toolchain working on my machine, there are a couple of other things I would like to do as I look through the code.

Thanks.

Paul

On Thu, Aug 12, 2010 at 2:04 PM, <[hidden email]> wrote:
Send eLua-dev mailing list submissions to
       [hidden email]

To subscribe or unsubscribe via the World Wide Web, visit
       https://lists.berlios.de/mailman/listinfo/elua-dev
or, via email, send a message with subject or body 'help' to
       [hidden email]

You can reach the person managing the list at
       [hidden email]

When replying, please edit your Subject line so it is more specific
than "Re: Contents of eLua-dev digest..."


Today's Topics:

  1. Cleaning the eLua svn repository (Martin Guy)
  2. Re: Cleaning the eLua svn repository (Bogdan Marinescu)
  3. Re: Adding other files to web builder (Dado Sutter)
  4. Re: Cleaning the eLua svn repository (Ryan Pusztai)
  5. Re: Cleaning the eLua svn repository (Bogdan Marinescu)
  6. Re: Cleaning the eLua svn repository (Dado Sutter)


----------------------------------------------------------------------

Message: 1
Date: Thu, 12 Aug 2010 13:06:46 +0200
From: Martin Guy <[hidden email]>
To: "eLua Users and Development List (www.eluaproject.net)"
       <[hidden email]>
Subject: [eLua-dev] Cleaning the eLua svn repository
Message-ID:
       <AANLkTikyQH=[hidden email]>
Content-Type: text/plain; charset=ISO-8859-1

Hi
 I just found the eLua coding style guidelines, which say:

3. line terminators: THIS IS IMPORTANT! Use UNIX style (LF) line
terminators, not DOS (CR/LF) or old Mac (CR) line terminators.

but the eLua source tree has a mixture of files with LF and with CRLF
line terminators.

Since this seems to be the reason my previous patches appied cleanly
in some environments and not in others, I wonder if it might be time
to run a script to sanitize all the elua source files, or whether that
might cause problems if people have large patch sets in the pipeline.
I'd guess it needs to be done at some point...

You can get a list of affected text files using
find . \( -name .svn -prune \) -o -type f | egrep -v
'\.(gif|png|jpg|bin)' | xargs grep -l '^M'
(where ^M is a real control character obtained by the sequence
control-V control-M)

I also notice that this also lists
 src/platform/stm32/FWLib/.sconsign.dblite
which is probably in the svn repository by mistake

cheers

   M


------------------------------

Message: 2
Date: Thu, 12 Aug 2010 14:10:09 +0300
From: Bogdan Marinescu <[hidden email]>
To: "eLua Users and Development List (www.eluaproject.net)"
       <[hidden email]>
Subject: Re: [eLua-dev] Cleaning the eLua svn repository
Message-ID:
       <[hidden email]>
Content-Type: text/plain; charset=ISO-8859-1

Hi Martin,

On Thu, Aug 12, 2010 at 2:06 PM, Martin Guy <[hidden email]> wrote:
> Hi
> ?I just found the eLua coding style guidelines, which say:
>
> 3. line terminators: THIS IS IMPORTANT! Use UNIX style (LF) line
> terminators, not DOS (CR/LF) or old Mac (CR) line terminators.
>
> but the eLua source tree has a mixture of files with LF and with CRLF
> line terminators.

Thank you very much for your reports. Yes, this happens a lot, mostly
when importend 3rd party files (for example support libraries) into
the eLua repository.

> Since this seems to be the reason my previous patches appied cleanly
> in some environments and not in others, I wonder if it might be time
> to run a script to sanitize all the elua source files, or whether that
> might cause problems if people have large patch sets in the pipeline.
> I'd guess it needs to be done at some point...

I do the kind of cleaning you mention below (NL translations) from
time to time, but not all the time, so accidents happen. Thanks for
reminding me that it needs to be done again.

> You can get a list of affected text files using
> find . \( -name .svn -prune \) -o -type f | egrep -v
> '\.(gif|png|jpg|bin)' | xargs grep -l '^M'
> (where ^M is a real control character obtained by the sequence
> control-V control-M)
>
> I also notice that this also lists
> ?src/platform/stm32/FWLib/.sconsign.dblite
> which is probably in the svn repository by mistake

Definitely. Thanks.

Best,
Bogdan


------------------------------

Message: 3
Date: Thu, 12 Aug 2010 11:55:43 -0300
From: Dado Sutter <[hidden email]>
To: "eLua Users and Development List (www.eluaproject.net)"
       <[hidden email]>
Subject: Re: [eLua-dev] Adding other files to web builder
Message-ID:
       <[hidden email]>
Content-Type: text/plain; charset="iso-8859-1"

Hello,

On Wed, Aug 11, 2010 at 20:03, Paul Verbeke <[hidden email]> wrote:

> Hi,
>
> I was looking through some old posts and it seems that someone else had a
> problem with MMC on the LM3S8962 board on April 22 2010. Mr Tze-Chien Chu
> found that in the platform_conf.h file line 191 that it should read as
> follows:
>
> #ifndef SDC_SPI_NUM <--- Original
>
> #ifndef MMCS_SPI_NUM <--- To be modified
>
> There is a good chance that this may be the problem with the LM3S6965 as
> well.
>

Sorry, I can't check this before next week.


> I tried in vain to add it to the ROMFS in the web builder but that did not
> work, did not really expect it to... Is there a way to add modified core
> files to replace the originals from the trunk to the build in addition to
> the ROMFS? I looked at the advanced settings too but could not find anything
> there.
>

Nope, not on the web builder (yet)

This would at least let users try out fixes like this beforehand.
>

The web builder was first targeted at Lua-only programmers that would have
too much trouble installing local toolchains. But it is nice to see it would
be trusted and used by hard-core developers, as we plan to add more and more
features to it.


> If this is not possible could someone that has the right setup build a
> binary with the above fix in it so I can try it?
>

Sure, I'll be glad to do it but not before next week :( I'm out of Rio and
I'll be offline from this afternoon until monday).
Maybe someone else from my Lab, let's see.


> Thanks,
>
> Paul
>


Thanks !
Best
Dado




>
>
>
> _______________________________________________
> eLua-dev mailing list
> [hidden email]
> https://lists.berlios.de/mailman/listinfo/elua-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.berlios.de/pipermail/elua-dev/attachments/20100812/9b528081/attachment-0001.html>

------------------------------

Message: 4
Date: Thu, 12 Aug 2010 11:36:38 -0400
From: Ryan Pusztai <[hidden email]>
To: "eLua Users and Development List (www.eluaproject.net)"
       <[hidden email]>
Subject: Re: [eLua-dev] Cleaning the eLua svn repository
Message-ID:
       <[hidden email]>
Content-Type: text/plain; charset="iso-8859-1"

On Thu, Aug 12, 2010 at 7:10 AM, Bogdan Marinescu <
[hidden email]> wrote:

> Hi Martin,
>
> On Thu, Aug 12, 2010 at 2:06 PM, Martin Guy <[hidden email]> wrote:
> > Hi
> >  I just found the eLua coding style guidelines, which say:
> >
> > 3. line terminators: THIS IS IMPORTANT! Use UNIX style (LF) line
> > terminators, not DOS (CR/LF) or old Mac (CR) line terminators.
> >
> > but the eLua source tree has a mixture of files with LF and with CRLF
> > line terminators.
>
> Thank you very much for your reports. Yes, this happens a lot, mostly
> when importend 3rd party files (for example support libraries) into
> the eLua repository.
>
> > Since this seems to be the reason my previous patches appied cleanly
> > in some environments and not in others, I wonder if it might be time
> > to run a script to sanitize all the elua source files, or whether that
> > might cause problems if people have large patch sets in the pipeline.
> > I'd guess it needs to be done at some point...
>
> I do the kind of cleaning you mention below (NL translations) from
> time to time, but not all the time, so accidents happen. Thanks for
> reminding me that it needs to be done again.
>
> > You can get a list of affected text files using
> > find . \( -name .svn -prune \) -o -type f | egrep -v
> > '\.(gif|png|jpg|bin)' | xargs grep -l '^M'
> > (where ^M is a real control character obtained by the sequence
> > control-V control-M)
> >
> > I also notice that this also lists
> >  src/platform/stm32/FWLib/.sconsign.dblite
> > which is probably in the svn repository by mistake
>
> Definitely. Thanks.


Why not use the SVN property 'svn:eol-style' and set it to "native".
--
Regards,
Ryan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.berlios.de/pipermail/elua-dev/attachments/20100812/15edcb81/attachment-0001.html>

------------------------------

Message: 5
Date: Thu, 12 Aug 2010 18:49:46 +0300
From: Bogdan Marinescu <[hidden email]>
To: "eLua Users and Development List (www.eluaproject.net)"
       <[hidden email]>
Subject: Re: [eLua-dev] Cleaning the eLua svn repository
Message-ID:
       <AANLkTi=[hidden email]>
Content-Type: text/plain; charset=ISO-8859-1

> Why not use the SVN property 'svn:eol-style' and set it to "native".

Mostly because I didn't know it exists :) Thanks, it looks as the
right solution for this problem. I vaguely remember using something
similar in CVS that caused a lot of headache, but I believe SVN can
handle this much better (mostly because it can differentiate between
text and binary files automatically).

Thanks,
Bogdan


------------------------------

Message: 6
Date: Thu, 12 Aug 2010 14:04:05 -0300
From: Dado Sutter <[hidden email]>
To: "eLua Users and Development List (www.eluaproject.net)"
       <[hidden email]>
Subject: Re: [eLua-dev] Cleaning the eLua svn repository
Message-ID:
       <[hidden email]>
Content-Type: text/plain; charset="iso-8859-1"

On Thu, Aug 12, 2010 at 12:36, Ryan Pusztai <[hidden email]> wrote:

>
> ................
> Why not use the SVN property 'svn:eol-style' and set it to "native".
>

Nice !


> --
> Regards,
> Ryan
>

Thank you guys for the report (and fix :)
Best
Dado



> _______________________________________________
> eLua-dev mailing list
> [hidden email]
> https://lists.berlios.de/mailman/listinfo/elua-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.berlios.de/pipermail/elua-dev/attachments/20100812/dbfe373b/attachment.html>

------------------------------

_______________________________________________
eLua-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/elua-dev


End of eLua-dev Digest, Vol 25, Issue 25
****************************************


_______________________________________________
eLua-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/elua-dev